(WorkAround) do while bug in latestest openbor version....

[MatMan]

The do while command doesn't work properly any more.

There seem to be no proper pattern as to when it will stop. It seem to go through all the loops even if found is set to 1. then I tried removing the < 11 condition and just set it to keep going till the found condition changes to 1 but its all messed up. I also tried placing else statments before all if statements.

I'm not sure when this problem occured but it this very command use to work flawlessly.

Just a side note that its happening to other do while commands that I have tried.

Code: [Select]

void changeweaponnext(void self)
{
  void weaponnumber = getCurrentWeapon(self);
  void found = 0;
  if ( self != NULL() && weaponnumber < 11 && found == 0 ) {
    do {
      weaponnumber = weaponnumber+1;
      if ( weaponnumber == 1 && getBeserk_wAmmo(self) > 0 && getBeserk_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 1);found = 1;}
      if ( weaponnumber == 2 && getShotgun_wAmmo(self) > 0 && getShotgun_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 2) ; settextobj(1, 185, 14, 3, 1, ""+getShotgun_wAmmo(self));found = 1;}
      if ( weaponnumber == 3 && getSuper_Shotgun_wAmmo(self) > 0 && getSuper_Shotgun_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 3) ; settextobj(1, 185, 14, 3, 1, ""+getShotgun_wAmmo(self));found = 1;}
      if ( weaponnumber == 4 && getChaingun_wAmmo(self) > 0 && getChaingun_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 4) ; settextobj(1, 185, 14, 3, 1, ""+getChaingun_wAmmo(self));found = 1;}
      if ( weaponnumber == 5 && getRocket_Launcher_wAmmo(self) > 0 && getRocket_Launcher_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 5) ; settextobj(1, 185, 14, 3, 1, ""+getRocket_Launcher_wAmmo(self));found = 1;}
      if ( weaponnumber == 6 && getPlasma_Gun_wAmmo(self) > 0 && getPlasma_Gun_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 6) ; settextobj(1, 185, 14, 3, 1, ""+getPlasma_Gun_wAmmo(self));found = 1;}
      if ( weaponnumber == 7 && getBFG_9000_wAmmo(self) > 0 && getBFG_9000_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 7) ; settextobj(1, 185, 14, 3, 1, ""+getPlasma_Gun_wAmmo(self));found = 1;}
      if ( weaponnumber == 8 && getChainsaw_wAmmo(self) > 0 && getChainsaw_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 8);found = 1;}
      if ( weaponnumber == 9 && getFlamethrower_wAmmo(self) > 0 && getFlamethrower_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 9);found = 1;}
  if ( weaponnumber == 10 && getSuper_Chaingun_wAmmo(self) > 0 && getSuper_Chaingun_wOwned(self) > 0 ) { changeentityproperty(self, "weapon", 10) ; settextobj(1, 185, 14, 3, 1, ""+getShotgun_wAmmo(self));found = 1;}
    } while (weaponnumber < 11 && found == 0 );

  }
  if (found == 0) { changeentityproperty(self, "weapon", 0); setCurrentWeapon(self, 0); } else { setCurrentWeapon(self, weaponnumber); }
}


[Damon Caskey]

A lot of bug reports have come in on the latest version. Clearly something went wrong, but atm I could not tell you what.

DC

[MatMan]

I try to go back to a older version of openBor but then the engine crashes without a error report so I'm kinda stuck  at the moment.

Its at a actual point where I want to download the source and start adding better reporting features (or actually missing) but I can't download from the svn.

[MatMan]

I landed changing the command to a for i command and it works 

Code: [Select]



int i = 0;
  for(i=0; i< maxWeapons; i++)                                                         //Loop entity collection.
  {
    weaponnumber = weaponnumber+1;
    if ( weaponnumber == 1 && getBeserk_wAmmo(self) > 0 && getBeserk_wOwned(self) > 0 ) {
      found = 1; i = maxWeapons+1; } else
    if ( weaponnumber == 2 && getShotgun_wAmmo(self) > 0 && getShotgun_wOwned(self) > 0 ) {
      found = 2; i = maxWeapons+1;} else
    if ( weaponnumber == 3 && getSuper_Shotgun_wAmmo(self) > 0 && getSuper_Shotgun_wOwned(self) > 0 ) {
      found = 3; i = maxWeapons+1; } else
    if ( weaponnumber == 4 && getChaingun_wAmmo(self) > 0 && getChaingun_wOwned(self) > 0 ) {
      found = 4; i = maxWeapons+1; } else
    if ( weaponnumber == 5 && getRocket_Launcher_wAmmo(self) > 0 && getRocket_Launcher_wOwned(self) > 0 ) {
      found = 5; i = maxWeapons+1; } else
    if ( weaponnumber == 6 && getPlasma_Gun_wAmmo(self) > 0 && getPlasma_Gun_wOwned(self) > 0 ) {
      found = 6; i = maxWeapons+1; } else
    if ( weaponnumber == 7 && getBFG_9000_wAmmo(self) > 0 && getBFG_9000_wOwned(self) > 0 ) {
      found = 7; i = maxWeapons+1; } else
    if ( weaponnumber == 8 && getChainsaw_wAmmo(self) > 0 && getChainsaw_wOwned(self) > 0 ) {
      found = 8; i = maxWeapons+1; } else
    if ( weaponnumber == 9 && getFlamethrower_wAmmo(self) > 0 && getFlamethrower_wOwned(self) > 0 ) {
      found = 9; i = maxWeapons+1; } else
    if ( weaponnumber == 10 && getSuper_Chaingun_wAmmo(self) > 0 && getSuper_Chaingun_wOwned(self) > 0 ) {
      found = 10; i = maxWeapons+1;}
  }