Merging panel and layer

[utunnels]

I'm working on merging fglayer, bglayer, panel and frontpanel to a single type called s_layer.
But I know someone must want script access to them.

The old functions changebglayerproperty and changefglayerproperty need to be updated or changed to fit the new layout. But since panels are technologically layers with zero bgspeedratio,  it would be hard for the modders to know their indices.

Any ideas?

[Bloodbane]

But since panels are technologically layers with zero bgspeedratio,  it would be hard for the modders to know their indices.

 Sorry, I'm lost here. Why do we need to know their indices?

[utunnels]

For script users of course.

If you want to change a layer property, you need to know its index.

Usually we define the level like this:

Code: [Select]

background blahblah... #layer 0
water blahblah...           #layer 1
bglayer blahblah....       #layer 2
bglayer blahblah....       #layer 3

panel  normal neon screen
panel  normal neon screen
panel  normal neon screen

order aabcccca # layer 4 onward

frontpanel blahblah...

fglayer blahblah...

[utunnels]

What, no one even complains?

 


Anyway, I've merged the 4 script functions to 2.

getlayerproperty(string type, int index, string property);
changelayerproperty(string type, int index, string property, value);

Type specifies the old type of the layer, it can be: background, bglayer, fglayer, panel, neon, screen, frontpanel, water and generic.


background - only one background available in a level, so just use 0 for index
bglayer - those you defined using bglayer in your level txt. The first one is 0, and so on.
fglayer - similar to bglayer.
panel - a panel, now same as other panels, only differs in properties. The index is given using order command.  So if you have order aabac, you have 5 panels. The order has nothing to do with panel command.
neon - a neon panel, the rule of index is same as above. But keep in mind not all panels have a neon, so this method could fail if the panel index you give don't have one.
screen - a screen panel, the rule of index is same as above. But keep in mind not all panels have a screen, so this method could fail if the panel index you give don't have one.
frontpanel - similar to panel, the order is same as how you define them.
water - usually there's only 1, but according to the new logic you can have many, though it is better to use bglayer instead.
generic - this has not been created. I reserved it for a new command that can use all properties of the layer structure.

[Bloodbane]

 I haven't tinkered with background control scripts yet so I can't say much. But I think it's enough.

water - usually there's only 1, but according to the new logic you can have many, though it is better to use bglayer instead.

 We can declare more waters now? never heard of it before.

[utunnels]

Water was just there to be backward compatible, it will be converted to a bglayer with water effect.
Everything is treated as a layer now.

Though you still can't have multiple background, the default palette logic of background must be kept for 8 bit mode. 


Oops, forgot to say, the build has not been compiled by the server.

[Plombo]

This change (SVN r3483) breaks Mr. Q's mod "Art of Fighting: Beats of Rage Remix III" when starting a new game.  It prints this error message to the log:

Code: [Select]

ERROR: load_level, file data/levels/begin01.txt, line 0, message: Level error: level has no panels
It might happen with other mods too; I haven't tested with anything else yet.

[utunnels]

Not sure about that issue.  level->numpanels is determined by order command. I can't see a reason why there's no panels.

Have you tried a more recent build?

[Plombo]

Not sure about that issue.  level->numpanels is determined by order command. I can't see a reason why there's no panels.

Have you tried a more recent build?

I'm running from the latest SVN.  I traced the issue to r3483 specifically after noticing it was broken.

[utunnels]

Do you know the content of the level txt?

[Plombo]

I can post it here:

Code: [Select]

music           data/music/MIX.bor
bossmusic data/music/BOSS1.bor
background data/bgs/s23/total2.gif
panel data/bgs/s23/n01.gif
direction       right
light  10   -30
at        0
settime         0
notime          1
noslow          1
order a
spawn1  105 20
spawn2  105 93
setweap 1
bgspeed 50 0

wall            400 260 0 0 100 100 300 1000

#-------1

spawn   intro01
flip    1
coords  0 276
at      0

spawn   ghost1
health  5
coords  530 220
at      0



[utunnels]

I can't reproduce the issue with the settings.

 

[Plombo]

Try downloading the mod and running it.

[utunnels]

It seems the mod is not on lavalit yet.

But I think I've found the problem.  I mistakenly used the wrong pointer in a memset call.

Edit*

Fixed.

[Plombo]

But I think I've found the problem.  I mistakenly used the wrong pointer in a memset call.

Edit*

Fixed.

I can confirm that it's fixed now.  Thanks!